Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to last stylus 0.50 #34

Closed
steida opened this issue Feb 25, 2015 · 5 comments
Closed

Update to last stylus 0.50 #34

steida opened this issue Feb 25, 2015 · 5 comments

Comments

@steida
Copy link

steida commented Feb 25, 2015

Update peerDependencies pls.

@shama
Copy link
Collaborator

shama commented Feb 25, 2015

How about I just set them to:

"peerDependencies": {
  "nib": ">=1.0.4",
  "stylus": ">=0.49.3"
},

then people can just install whichever version they want. What do you think?

Tests are currently broken with the latest though. It'd be nice if someone helped fix that.

@steida
Copy link
Author

steida commented Feb 25, 2015

I would remove them. It seems peerDependencies are going to be removed npm/npm#6565

@steida
Copy link
Author

steida commented Mar 2, 2015

Ok, I just realised that I don't have to require stylus, just stylus-loader. Sorry.

@steida steida closed this as completed Mar 2, 2015
@SimenB
Copy link
Contributor

SimenB commented Jul 14, 2015

@shama Could you update the version now?

Also peerDependecies aren't going to be removed, they are going to stop being automatically installed, so it's the consumer's responsibility to provide the package (by depending on it). So if you'd like, putting stylus as a peerDep would allow us to update independently from this plugin (or just make the version you require be *, if that's feasible).

Edit: I need it updated to get ranges.

I'd like this:

for i in range(10, 100, 10) {
  .width-{i}-proc {
    width: '%s%' % i;
  }
}

to be expanded to

.width-10-proc {
  width: 10%;
}
.width-20-proc {
  width: 20%;
}
.width-30-proc {
  width: 30%;
}
.width-40-proc {
  width: 40%;
}
.width-50-proc {
  width: 50%;
}
.width-60-proc {
  width: 60%;
}
.width-70-proc {
  width: 70%;
}
.width-80-proc {
  width: 80%;
}
.width-90-proc {
  width: 90%;
}
.width-100-proc {
  width: 100%;
}

and not

.width--proc {
  width: range(10, 100, 10)%;
}

@SimenB
Copy link
Contributor

SimenB commented Aug 12, 2015

@shama ping 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants