Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quartz/PD modes are actually styles? #165

Closed
shamansir opened this issue Aug 25, 2015 · 7 comments
Closed

Quartz/PD modes are actually styles? #165

shamansir opened this issue Aug 25, 2015 · 7 comments
Labels
could-change-api docs rendering
Milestone
v2.0.x

Comments

@shamansir
Copy link
Owner

No description provided.

@shamansir shamansir added this to the v0.2.0 milestone Aug 25, 2015
@shamansir shamansir changed the title Rename quart/pd modes to horizontal/vertical Rename quartz/pd modes to horizontal/vertical Aug 25, 2015
@shamansir
Copy link
Owner Author

Since RPD still have in plans PD toolkit implementation, Quartz/PD names for the modes are confusing. They could be not exactly horizontal/vertical though, but some other nice way to name them.

Relates to #80

@shamansir
Copy link
Owner Author

May be their names are just fine, but we should consider them "styles"?
But what is the way to extract them from renderers then?

@shamansir shamansir changed the title Rename quartz/pd modes to horizontal/vertical Quartz/pd modes are actually styles? Sep 11, 2015
@shamansir shamansir modified the milestones: Undefined, v0.2.0 Sep 11, 2015
@shamansir shamansir changed the title Quartz/pd modes are actually styles? Quartz/PD modes are actually styles? Sep 11, 2015
@shamansir shamansir mentioned this issue Sep 12, 2015
Closed
@shamansir shamansir modified the milestones: v0.2.0, Undefined Sep 12, 2015
@shamansir shamansir mentioned this issue Sep 12, 2015
Closed
@shamansir
Copy link
Owner Author

Same way, B/W styles could be "styles", with their construction code and .css files

This was referenced Sep 12, 2015
Closed
Merged
@shamansir
Copy link
Owner Author

Fixed with #188 (SVG styles are not yet moved)

@shamansir shamansir mentioned this issue Sep 21, 2015
Merged
@shamansir
Copy link
Owner Author

SVG styles were moved in #190

@shamansir
Copy link
Owner Author

Only SVG .css files are not yet separated.

@shamansir
Copy link
Owner Author

finally done in 1068a94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
could-change-api docs rendering
Projects
None yet
Milestone
v2.0.x
Development

No branches or pull requests
1 participant
@shamansir