Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on win7, the settings are uploaded and syned, however, on ubuntu, the extensions are not synced! #213

Closed
jonygli opened this issue Feb 13, 2017 · 9 comments

Comments

@jonygli
Copy link

jonygli commented Feb 13, 2017

Visual Studio Code Version : [ 1.9.1]
Code Settings Sync Version : [ 2.4.3]
Operating System : [ ubuntu 16.04 ]
Occurs On: [Download]
Proxy Enabled: [ Yes ]
GIst Id: [ 4f15b34b7eed738e4854cb6f37409b73 ]

on win7, the settings are uploaded and syned, however, on ubuntu, the extensions are not synced!

@jonygli
Copy link
Author

jonygli commented Feb 14, 2017

it seems the extensions can be synced and installed only at the 1st time. after then, extensions can't be synced and installed.

@jonygli jonygli changed the title on win7, the settings are uploaded and syned, however, on ubuntu, the extensions are noted synced! on win7, the settings are uploaded and syned, however, on ubuntu, the extensions are not synced! Feb 14, 2017
@shanalikhan
Copy link
Owner

is there any exception logged in console.

@xubo-bj
Copy link

xubo-bj commented Feb 15, 2017

I met the same problem, upload from win7 then download to ubuntu 16.04.
another extensions "Syncing" can work on win7 and ubuntu

@UserRandom
Copy link

Same issue, although between different operating systems. Started relatively recently. Possibly related to #206 .

@generalov
Copy link

generalov commented Feb 16, 2017

Probably it could be solved if change the sync.lastDownload option value in User settings from the null to the same string date value as sync.lastUpload has (or may be just to the empty string).

I've got the same ussue on Ubuntu 16.10 and debugged the extension.
The exception is raised on https://github.com/shanalikhan/code-settings-sync/blob/master/src/extension.ts#L303

let lastDownloadStr: string = syncSetting.lastDownload.toString();

because the syncSetting.lastDownload has the undefined value.

@shanalikhan
Copy link
Owner

@generalov Thanks!
i have replaced it by additional undefined check.

let lastUploadStr: string = (syncSetting.lastUpload) ? syncSetting.lastUpload.toString(): "";
let lastDownloadStr: string = (syncSetting.lastDownload) ? syncSetting.lastDownload.toString(): "";

#206 also tried to solve similar work, i will publish this in newer version so you all can check it out.

@shanalikhan
Copy link
Owner

I have release a update for Code Insiders, if anyone is using Insiders please let me know if it worked i will release for public, I have tested and its working for me.

@shanalikhan
Copy link
Owner

Public build released v2.4.4 Fixing this issue
Let me know if there is some problem.

@generalov
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants