Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling gist repo every 5 mins to detect change when Auto-download enabled #984

Open
allenyllee opened this issue Jul 25, 2019 · 2 comments

Comments

@allenyllee
Copy link

馃挕 Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Suppose I have 2 PCs, called "HOME-PC" and "WORK-PC", both have VScode opened. When I worked on WORK-PC, change some settings and upload (by auto-upload), I have no way to notify HOME-PC to do the download (because auto-download only trigger on vscode startup).

馃挕 Describe the solution you'd like
A clear and concise description of what you want to happen.

I think the auto-download function should polling the gist repo every 5 mins to detect changes, if there are changes, then just download it.

馃挕 Additional context
Add any other context or screenshots about the feature request here.

@Will-W
Copy link

Will-W commented Sep 5, 2019

5 minutes might be overkill. For my use case (very similar to @allenyllee) 'once an hour' would be easily sufficient.

The problem is when you have two long running VSCode instances on two different machines (home and work), the sequence is:

  • Change settings on HOME
  • Go to work - forget about changes that I might have made several days previously, so I haven't manually called download
  • Change settings on WORK
  • Get the Gist has newer or identical version of your settings message. Have to decide which setting I'm keeping (usually, force download then reapply whatever I just changed)

The time interval is effectively 'how quickly am I going to go from one machine I'm configuring to another'. Possibly configurable, default to a long interval (so not too much unnecessary work) and let people who switch machines rapidly configure a shorter interval.

@allenyllee
Copy link
Author

@Will-W Well, but actually I have two PC in my work place, one is Windows and the other is Ubuntu. I constantly switching between them. So I think 5 minutes is acceptable, 1 hr is too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants