New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should rewrite getByte(c) without try-catch #38

Open

MetaMemoryT opened this issue Feb 11, 2015 · 1 comment

MetaMemoryT commented Feb 11, 2015

https://github.com/shaneGirish/bcrypt-nodejs/blob/master/bCrypt.js#L235

http://jsperf.com/try-catch-performance-overhead

and it pollutes debugging with extra exceptions being thrown

Contributor

fpirsch commented Feb 11, 2015

If you want performance, maybe you should take a look at Twin-Bcrypt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment