Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't copy timelink #49

Closed
lordfiSh opened this issue Jun 6, 2022 · 7 comments
Closed

can't copy timelink #49

lordfiSh opened this issue Jun 6, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@lordfiSh
Copy link

lordfiSh commented Jun 6, 2022

If I click on the Time link Icon nothing happens,
this shows up in the console: image

@Shane-stage
Copy link

Interesting, I wonder if its browser specific. What browser are you using? Any chance you could try another browser like chrome/firefox?

@Shane-stage
Copy link

Looking into this a little bit, it seems that writing to the clipboard only works under a secure https protocol. If you set the server up under https it should work. Is it only the time stamped link that fails with this error or does the regular link share button also cause the same error?

@lordfiSh
Copy link
Author

lordfiSh commented Jun 6, 2022

Vivaldi , but same on Edge. Can test https later...

Normal Linking works:
image
but you only get to a 404, nginx Page

@Shane-stage
Copy link

Interesting, I think I have a fix for the copying so that it works on non https as well. (I'll try to get that in later today on my lunch or after work). On the 404 issue, can you share the link path its giving you?

I'm assuming you are running this via docker as well correct? If not, I know why you're getting the 404.

@lordfiSh
Copy link
Author

lordfiSh commented Jun 6, 2022

The Unraid Docker Container from you ;)

The Copy Option from the Thumbnail works just fine, but the Button from the Video is missing the w/ in the URL

@Shane-stage
Copy link

Shane-stage commented Jun 6, 2022

Oh yes I see it now. Its the copy button on the /w/ page that is broken.

Thank you for pointing both of these issue out. I'll try to have a fix for them this afternoon. I'll close this issue once I have a fix pushed later.

@ShaneIsrael ShaneIsrael added the bug Something isn't working label Jun 6, 2022
@ShaneIsrael
Copy link
Owner

ShaneIsrael commented Jun 6, 2022

Fixed in PR #53

Should be updated if you pull the latest tag down in a couple minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants