Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight cleanup #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Slight cleanup #2

wants to merge 4 commits into from

Conversation

mjtorn
Copy link

@mjtorn mjtorn commented Mar 9, 2022

I messed around with the code, and figured I don't want to wait for the script to rip frames when I had problems, and then I also tweaked the code a bit to get acquainted with it and see if it would become cleaner.

@mjtorn
Copy link
Author

mjtorn commented Mar 11, 2022

Printing the files was sort of my debug to ensure the sorting works, but it looks distracting and annoying, so I force-pushed a cleanup to it.

@shangar21 shangar21 self-requested a review March 11, 2022 15:50
@mjtorn
Copy link
Author

mjtorn commented Mar 12, 2022

I highly doubt it's this PR, but I ended up with a video with only a black picture, nothing real.

 (+) Video --vid=1 (*) (h264 2880x2304 25.000fps)
 (+) Audio --aid=1 (*) (mp3 2ch 44100Hz)
AO: [pulse] 44100Hz stereo 2ch float
VO: [gpu] 2880x2304 yuv420p

I'll open an issue about this later unless I find a resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant