Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update structure of internals with all the stacking...so much stacking #126

Closed
ddsjoberg opened this issue Apr 5, 2022 · 0 comments · Fixed by #175
Closed

Update structure of internals with all the stacking...so much stacking #126

ddsjoberg opened this issue Apr 5, 2022 · 0 comments · Fixed by #175
Assignees

Comments

@ddsjoberg
Copy link
Collaborator

At the moment, when both soc and ae are specified, each section of SOC is 2 separate tbl_summary() tbls: one for the SOC and one for the AEs that are then stacked. THEN each SOC group is then stacked. This is a lot of duplicated work within the many calls to tbl_summary()

I think it would be faster if we built one tbl_summary() for all the AEs and one tbl_summary() for all the SOCs. We could then split the tables by SOC and make a single tbl_stack() for all the tbls.

@shannonpileggi is it ever possible that an AE term can appear within two or more SOCs? This would mess up the merging of the SOC terms and this approach would not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant