Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot "Open Windows Terminal Here" on a drive root #4

Closed
jeremyVignelles opened this issue Feb 15, 2020 · 5 comments 路 Fixed by #7
Closed

Cannot "Open Windows Terminal Here" on a drive root #4

jeremyVignelles opened this issue Feb 15, 2020 · 5 comments 路 Fixed by #7

Comments

@jeremyVignelles
Copy link

Hi,
Thanks for the file and the blog post, I'll be using wt everyday now 馃槃

Now, when I right click on a drive from "This PC" and select "Open Windows Terminal Here", I get this:

[error 0x8007010b when launching `powershell.exe']

Did I do something wrong?

Please note that I downloaded the .inf from #3 instead of the master one, because I wanted to right click inside a folder. When I do it inside, the issue is still the same, but it works fine on other folders.

@etheralm
Copy link

you can fix it by opening regedit and changing in Computer\HKEY_CLASSES_ROOT\Drive\shell\WindowsTerminalHere\command
"%1" to "%1\"
to fix the background right click in a drive root (the addition from the pull request) you have to change in Computer\HKEY_CLASSES_ROOT\Directory\Background\shell\WindowsTerminalHere\command
"%V" to "%V\."

you can find more info about this issue here: microsoft/terminal#4571

cheers

@chungweileong94
Copy link
Contributor

I'm already fixed in my fork, thanks to the info from @etheralm

However, I did modify something in my fork to fit my own preference, so I'm not sure if I wanted to create a PR for this. Here are the changes I made:

  • Change the "Windows Terminal Here" label to "Open Windows Terminal Here"
  • Added "Open Windows Terminal Here" to directory background
  • Fixed "Open Windows Terminal Here" on drive root

@shanselman
Copy link
Owner

Cool @chungweileong94! Send it over!

@chungweileong94
Copy link
Contributor

@shanselman Sorry for the double PR, I'm still new to the GitHub world

@jawn
Copy link
Contributor

jawn commented Feb 20, 2020

@shanselman Sorry for the double PR, I'm still new to the GitHub world

Hey @chungweileong94 , thanks for getting involved 馃殌 and improving open source software!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants