Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GradientThreshold=36 cannot reprodue example in paper #4

Open
geroldmeisinger opened this issue Sep 20, 2023 · 1 comment
Open

GradientThreshold=36 cannot reprodue example in paper #4

geroldmeisinger opened this issue Sep 20, 2023 · 1 comment

Comments

@geroldmeisinger
Copy link

geroldmeisinger commented Sep 20, 2023

Thank you for your implementation!

I'm using your program over at lllyasviel/ControlNet#318
However with the default settings using gradientThreshold=36 I'm not able to reproduce the examples in the paper.
I assume the value is derived from "Figure 1 shows the edge areas corresponding to our test image for a threshold value of 36. White edge areas correspond to pixels for which Gx + Gy >= 36. Black pixels are suppressed as non-edges.". The same value is used in the cpp implementaion https://github.com/hongxinliu/edge-drawing/blob/master/include/ed.hpp

implementation by original author https://github.com/CihanTopal/ED_Lib

Figure 1. High-pass filtering residue of Lena image.
image


gradientThreshold=36

Gradient


gradientThreshold=10
Gradient

@Yikkkkk
Copy link

Yikkkkk commented Mar 12, 2024

hello! would you tell me the IR and IR_GT? Maybe there are dataset? thanks your repley~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants