Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English translation #3

Open
arthurlutz opened this issue Nov 7, 2021 · 6 comments
Open

English translation #3

arthurlutz opened this issue Nov 7, 2021 · 6 comments

Comments

@arthurlutz
Copy link

Hi 👋

Great project, works out of the box for my node-red setups that collect temperatures and humidity and I finally got those as discovered items in home-assistant ! In a few clicks ! Thanks !

Any chance I can contribute an english (and french?) translation ?

@shaonianzhentan
Copy link
Owner

Thank you. But I'm not familiar with the translation code of node-red

@tito
Copy link

tito commented Nov 10, 2021

If translation is done, would you accept the PR ?

@shaonianzhentan
Copy link
Owner

shaonianzhentan commented Nov 12, 2021

Sure

@benfiglin
Copy link
Contributor

@shaonianzhentan Please close PR #4. This is incomplete work and contains other things besides a translation. It was never ready for a PR but someone decided to do the PR from my fork without even checking with me.

@benfiglin
Copy link
Contributor

Hello @shaonianzhentan,

The above PR #6 adds English, while still keeping the Chinese language intact.

Please check it,
Thank you!

@shaonianzhentan
Copy link
Owner

Hello @benfiglin

I've publish it to NPM

Thank you for your translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants