Lots of compiler warnings

[jcoliz]

@ashahabov Compiling generates many warnings. Would you take a PR to clean these up?

Logger\SCLogger.cs(23,9): warning CS0162: Unreachable code detected
Presentations\Slides.cs(150,30): warning CS0168: The variable 'sourcePresDoc' is declared but never used
Texts\TextParagraphPortion.cs(81,28): warning CS8629: Nullable value type may be null.
SlideMasters\ISlideMasterCollection.cs(32,13): warning CS0219: The variable 'number' is assigned but its value is never used
SlideMasters\SlideLayouts.cs(22,13): warning CS0219: The variable 'number' is assigned but its value is never used 
ShapeCrawler\Texts\Field.cs(86,28): warning CS8629: Nullable value type may be null. 
Charts\Chart.cs(20,32): warning CS0169: The field 'Chart.chartType' is never used
Colors\Color.cs(95,22): warning CS1572: XML comment has a param tag for 'result', but there is no parameter by that name
IShape.cs(129,96): warning CS1574: XML comment has cref attribute 'Audio' that could not be resolved 
ShapeCollection\IShape.cs(129,144): warning CS1574: XML comment has cref attribute 'Video' that could not be resolved 

[ashahabov]

Yes, it would be good👍 But it is very desirable to do it through setting .severity = error in .editorconfig if possible, otherwise as practice shows such a thing always falls into the master🙂

[yogendrasgautam]

@jcoliz Is this issue still open, Can I start working on it ?

[ashahabov]

@yogendrasgautam, thank you for the interest.

Yes, the issue is open. There are still warnings left.

[yogendrasgautam]

@ashahabov thanks for confirmation. Will take a look into it

[jcoliz]

@ashahabov @yogendrasgautam Fascinating! Which warnings? It's clean for me...

PS C:\Source\jcoliz\ShapeCrawler> dotnet build
  Determining projects to restore...
  All projects are up-to-date for restore.
  ShapeCrawler.Tests.Shared -> C:\Source\jcoliz\ShapeCrawler\test\ShapeCrawler.Tests.Shared\bin\Debug\netstandard2.0\Sh
  apeCrawler.Tests.Shared.dll
  ShapeCrawler -> C:\Source\jcoliz\ShapeCrawler\src\ShapeCrawler\bin\Debug\net8.0\ShapeCrawler.dll
  ShapeCrawler.Tests.Unit.xUnit -> C:\Source\jcoliz\ShapeCrawler\test\ShapeCrawler.Tests.Unit.xUnit\bin\Debug\net8.0\Sh
  apeCrawler.Tests.Unit.xUnit.dll
  ShapeCrawler.Tests.Integration -> C:\Source\jcoliz\ShapeCrawler\test\ShapeCrawler.Tests.Integration\bin\Debug\net8.0\
  ShapeCrawler.Tests.Integration.dll
  ShapeCrawler.Tests.Unit -> C:\Source\jcoliz\ShapeCrawler\test\ShapeCrawler.Tests.Unit\bin\Debug\net8.0\ShapeCrawler.T
  ests.Unit.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.72

[jcoliz]

Ok, nevermind, I see them! They only come up in release configuration. 96 warnings cluttering up my release pipeline 😄