Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving visvalingam performance by 3x. #134

Merged
merged 7 commits into from Sep 4, 2019

Conversation

avilchess
Copy link
Contributor

Make sure you have checked all steps below.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

  • My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

  • My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

License

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #134 into master will decrease coverage by 0.28%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage    97.6%   97.31%   -0.29%     
==========================================
  Files          17       17              
  Lines        1879     1901      +22     
==========================================
+ Hits         1834     1850      +16     
- Misses         45       51       +6
Impacted Files Coverage Δ
src/khiva/dimensionality.cpp 96.97% <97.43%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc7fe6...6cab89d. Read the comment docs.

@@ -611,29 +612,83 @@ af::array khiva::dimensionality::SAX(af::array a, int alphabet_size) {
return result;
}

struct VisagramPoint{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is my fault. It should be renamed to Visvalingam.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, hehehehe

@jrecuerda
Copy link
Contributor

LGTM

Copy link
Contributor

@jrecuerda jrecuerda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avilchess avilchess merged commit 3d046ee into master Sep 4, 2019
@avilchess avilchess deleted the feature/VisvalingamImprove branch September 4, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants