New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving visvalingam performance by 3x. #134
Conversation
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 97.6% 97.31% -0.29%
==========================================
Files 17 17
Lines 1879 1901 +22
==========================================
+ Hits 1834 1850 +16
- Misses 45 51 +6
Continue to review full report at Codecov.
|
src/khiva/dimensionality.cpp
Outdated
@@ -611,29 +612,83 @@ af::array khiva::dimensionality::SAX(af::array a, int alphabet_size) { | |||
return result; | |||
} | |||
|
|||
struct VisagramPoint{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is my fault. It should be renamed to Visvalingam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, hehehehe
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Make sure you have checked all steps below.
Description
Tests
Benchmarks
Commits
License
Documentation