Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/headers bindings #79

Merged
merged 2 commits into from Feb 10, 2019
Merged

Feature/headers bindings #79

merged 2 commits into from Feb 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2019

Description

  • Added headers guards for avoid double inclusions.

Tests

  • My PR does not need testing because it does not add any functional feature

Benchmarks

  • My PR does not need benchmarks because are only changes in include for avoid double inclusions.

Commits

  • Add headers guards in bindings includes for C and Java.

License

@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          13       13           
  Lines        1511     1511           
=======================================
  Hits         1490     1490           
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32010d0...4826e09. Read the comment docs.

Copy link
Contributor

@avilchess avilchess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avilchess avilchess merged commit 1536190 into shapelets:master Feb 10, 2019
@avilchess
Copy link
Contributor

Good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants