Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 for Windows (AppVeyor) #10

Merged
merged 2 commits into from Feb 11, 2022
Merged

Conversation

mwtoews
Copy link
Member

@mwtoews mwtoews commented Nov 5, 2021

Looks like the binary wheels for Python 3.10 on Windows could be built.

Closes shapely/shapely#1215

@mwtoews
Copy link
Member Author

mwtoews commented Nov 8, 2021

The last commit can be rolled back after shapely/shapely#1224 is merged

@jorisvandenbossche
Copy link
Member

This is passing, so can be merged?

@mwtoews
Copy link
Member Author

mwtoews commented Nov 8, 2021

Second commit is now changed to re-sync the Shapely submodule to maint-1.8 with the cython version. So yes, ready to merge now.

@jorisvandenbossche
Copy link
Member

If we want to still publish python 3.10 wheels for the existing shapely 1.8.0 release, don't you need to keep the cython update here? (instead of getting it from an updated shapely)
(not super familiar with how this repo works, so just a question)

@mwtoews
Copy link
Member Author

mwtoews commented Nov 8, 2021

For an update to the PyPI files for the 1.8.0 release, probably yes. The previous CI run result is here and the two wheel artefacts could be manually added to the existing release on PyPI. But I'll let @sgillies decide what to do.

@sgillies
Copy link
Collaborator

Merging this in case the new GHA workflow nirvana can't be realized.

@sgillies sgillies merged commit ea124b7 into shapely:master Feb 11, 2022
@mwtoews mwtoews deleted the win-py310 branch February 11, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues installing shapely 1.8.0 on windows python 3.10 (amd64)
3 participants