Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Generation: Cleanup #36

Closed
kaladinlight opened this issue Sep 17, 2021 · 0 comments · Fixed by #40
Closed

Code Generation: Cleanup #36

kaladinlight opened this issue Sep 17, 2021 · 0 comments · Fixed by #40
Assignees
Projects

Comments

@kaladinlight
Copy link
Collaborator

We don't need to be checking in all of the generated code, but we do want to ensure the most recent generated code in a few circumstances.

  • coinstacks/api/src/routes.ts does not need to be tracked. this is automatically generated on yarn build and kept up to date during development. We run yarn build and persist the workspace in CircleCI, so we will have the routes available for deployed image.
  • coinstacks/api/src/swagger.json should be tracked. There is currently a pre-push hook that runs generate, but it is easy to miss the update and merge without actually committing the most recent swagger. It would be ideal to pull this out so that on merge, we run generate on the project and commit any swagger changes before merge to ensure they are up to date in the repository.
  • packages/client/src/generated does not need to be tracked. We should set up a way to handle hot regeneration of the client for development. Right now publishing is manual, we will want to generate and publish this package after deployment of coinstacks.
@kaladinlight kaladinlight self-assigned this Sep 21, 2021
@kaladinlight kaladinlight added this to the Minimum Lovable Product milestone Sep 21, 2021
@kaladinlight kaladinlight added this to To do in Engineering via automation Sep 21, 2021
@kaladinlight kaladinlight moved this from To do to In progress in Engineering Sep 21, 2021
@kaladinlight kaladinlight linked a pull request Sep 21, 2021 that will close this issue
@kaladinlight kaladinlight moved this from In progress to Review in progress in Engineering Sep 23, 2021
Engineering automation moved this from Review in progress to Done Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant