Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Controller type check errors #51

Closed
kaladinlight opened this issue Sep 27, 2021 · 1 comment
Closed

API Controller type check errors #51

kaladinlight opened this issue Sep 27, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@kaladinlight
Copy link
Collaborator

Currently all errors are being treated as axios errors, but this is an incorrect assumption and we should ultimately use proper type checking on errors (treating err as unknown) so we handle all error types correctly
@kaladinlight kaladinlight added the enhancement New feature or request label Oct 7, 2021
@theoboldfrazier
Copy link
Contributor

@elmutt Can you look into this and close if no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
ShapeShift Dashboard
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaladinlight @theoboldfrazier