Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit Modal on the DeFi page in mobile looks a bit messy #1381

Closed
2 tasks done
MBMaria opened this issue Apr 4, 2022 · 2 comments · Fixed by #1382
Closed
2 tasks done

Deposit Modal on the DeFi page in mobile looks a bit messy #1381

MBMaria opened this issue Apr 4, 2022 · 2 comments · Fixed by #1382
Assignees
Labels
needs engineering Requires engineering input before bounty needs product Requires product input before bounty
Projects

Comments

@MBMaria
Copy link

MBMaria commented Apr 4, 2022

Overview

When staking an asset in the Yearn Vault on mobile, the modal pop out is larger than the screen so you can't see the whole modal in one go. When moving the modal across, the screen behind can be seen in certain parts and it makes it hard to read

References and additional details

  1. Open app.shapeshift in mobile (using PR release https://7b79acc7.web-29e.pages.dev/ )
  2. Connect to any wallet
  3. Select DeFi page and choose an asset to open the Yearn Vault modal.
  4. Select Deposit and notice the bottom part of the modal is too wide for the screen and you cannot see the entire modal
  5. Once selecting amount to deposit, select continue and notice the same thing on the following page. When moving the modal across the screen, you can see the information from the previous page behind and it makes It hard to read.
    image
    image

Acceptance Criteria

Should be able to view modal easily when staking as asset

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added needs engineering Requires engineering input before bounty needs product Requires product input before bounty labels Apr 4, 2022
@Lychbot Lychbot added this to Backlog in Bug Board Apr 5, 2022
@NeOMakinG
Copy link
Contributor

I'll apply on this one when it's out

@reallybeard
Copy link
Contributor

I'll apply on this one when it's out

@NeOMakinG
I'm gonna pick this up, since its part of the FOXY stuff.. and I borked it. Much appreciated though!

@Lychbot Lychbot moved this from Backlog to Done in Bug Board Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering input before bounty needs product Requires product input before bounty
Projects
Development

Successfully merging a pull request may close this issue.

3 participants