Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching Wallets Import Seed Issues - From any wallet to Native on mobile #1400

Closed
2 tasks done
wesleygravess opened this issue Apr 6, 2022 · 13 comments · Fixed by #1521
Closed
2 tasks done

Switching Wallets Import Seed Issues - From any wallet to Native on mobile #1400

wesleygravess opened this issue Apr 6, 2022 · 13 comments · Fixed by #1521
Assignees
@0xApotheosis
Labels
bounty Issue is posted in dework.xyz as a bounty

Comments

@wesleygravess
Copy link

wesleygravess commented Apr 6, 2022 •
edited by 0xApotheosis

Overview

When switching wallets on mobile (iOS and Android), from any wallet to native, attempting to import a native seed won't allow you to type in the phrase, the keyboard doesn't come up.

The same issue also occurs when switching to a Native wallet (tested from Portis) and attempting to create a new wallet - the user is unable to type the wallet name or password to continue.

References and additional details

  1. go to app.shapeshift.com
  2. log in with a wallet.
  3. switch to a native wallet, and choose import a wallet.
  4. try typing in your seed and observe that you can't click inside the text box and a keyboard does not come up.

Acceptance Criteria

The user should be able to click inside the text box on the import or create wallet page and a keyboard should come up, allowing them to type inside the box - this should work on iOS and Android.

Need By Date

No response

Screenshots/Mockups

RPReplay_Final1649200776_Trim.mp4

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

Half a day.

Sponsor / Stakeholder

github: 0xApotheosis discord: 0xApotheosis#2503

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@wesleygravess wesleygravess added the needs product Requires product input before bounty label Apr 6, 2022
@0xean 0xean added blocker and removed blocker labels Apr 6, 2022
@DiggyDiggy2 DiggyDiggy2 added needs engineering Requires engineering input before bounty and removed needs product Requires product input before bounty labels Apr 6, 2022
@DiggyDiggy2
Copy link
Collaborator

This appears to be a bug. That keyboard should slide up. Maybe something weird with that text area.

@0xApotheosis 0xApotheosis self-assigned this Apr 7, 2022
@0xApotheosis
Copy link
Contributor

0xApotheosis commented Apr 7, 2022 •
edited

@wesleygravess to be explicit here, it looks like this issue was observed on Safari - can you please confirm?

And was it observed on any other browsers?

@mrnerdhair
Copy link
Contributor

(curious about this; dropping a comment so I'll get a notification as it progresses)

@0xApotheosis
Copy link
Contributor

(curious about this; dropping a comment so I'll get a notification as it progresses)

You can also "Subscribe" to issues directly in the right-side sidebar.

@0xApotheosis 0xApotheosis changed the title Switching Wallets Import Seed Issues - From Portis to Native iOS mobile Switching Wallets Import Seed Issues - From any wallet to Native on mobile Apr 12, 2022
@0xApotheosis 0xApotheosis added needs bounty Issues that should be bountied. and removed needs engineering Requires engineering input before bounty needs operations labels Apr 12, 2022
@mrnerdhair
Copy link
Contributor

TIL!

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 870.0 FOX (320.55 USD @ $0.37/FOX) attached to it as part of the shapeshift fund.

@purelycrickets purelycrickets added bounty Issue is posted in dework.xyz as a bounty and removed needs bounty Issues that should be bountied. labels Apr 15, 2022
@NeOMakinG
Copy link
Contributor

NeOMakinG commented Apr 19, 2022 •
edited

I investigated!

Probably not the best way to fix it but it seems that the navigation Drawer has a focus trap, adding trapFocus={false} to the Drawer here fixes it.

Noticed that the WalletViewsSwitch modal has a trapFocus={false}, but removing it doesn't change anything...

It's breaking the accessibility as you can't spam tab anymore with the focus trapped inside the navigation drawer, but I guess it's a minor usage as it's mainly on the mobile side

Probably a problem from:

  • A wrong modal usage from us
  • A wrong Chakra UI modal/drawer behavior

@reallybeard can I get your input on this? Can we disable the trap?

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Apr 19, 2022 •
edited

@0xApotheosis The issue is reproducible directly on your desktop browser using the responsive view while opening dev tools, I tested with a chromium-based one.

@reallybeard
Copy link
Contributor

reallybeard commented Apr 19, 2022 •
edited

I investigated!

Probably not the best way to fix it but it seems that the navigation Drawer has a focus trap, adding trapFocus={false} to the Drawer here fixes it.

Noticed that the WalletViewsSwitch modal has a trapFocus={false}, but removing it doesn't change anything...

It's breaking the accessibility as you can't spam tab anymore with the focus trapped inside the navigation drawer, but I guess it's a minor usage as it's mainly on the mobile side

Probably a problem from:

  • A wrong modal usage from us
  • A wrong Chakra UI modal/drawer behavior

@reallybeard can I get your input on this? Can we disable the trap?

Could we collapse the drawer when you click switch wallet, or really any link from the drawer? I feel like that would fix the issue. As this behavior only seems to happen when the drawer has focus.

@NeOMakinG
Copy link
Contributor

Pretty intelligent, how would you manage that? I guess you need to use the useDisclosure hook with the Drawer id

@reallybeard
Copy link
Contributor

Let me try something out, and get back to you @NeOMakinG

@reallybeard reallybeard mentioned this issue Apr 19, 2022
Merged
5 tasks
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 870.0 FOX (309.97 USD @ $0.36/FOX) attached to this issue has been cancelled by the bounty submitter

@0xApotheosis
Copy link
Contributor

Nailed it @reallybeard 🦊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xApotheosis 0xApotheosis

Labels
bounty Issue is posted in dework.xyz as a bounty
Projects
ShapeShift Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: collapse drawer when menu item is clicked shapeshift/web
9 participants
@mrnerdhair @NeOMakinG @0xean @gitcoinbot @reallybeard @DiggyDiggy2 @purelycrickets @0xApotheosis @wesleygravess