Password not working when switching to Native wallet

[MBMaria]

Overview

When switching wallets to Native from any other wallet, when you entering the password it states that the password is invalid. If you just cancel out of that modal, the wallet will load as usual. Even if you don't enter any password at all and exit the password modal, the wallet will load.

References and additional details

1. Log into app.shapeshift.com and connect to native wallet.
2. Switch to any other wallet.
3. Switch back to native wallet.
4. When prompted for password note that when entering the correct password is comes up with the error "invalid password".
5. Note that you can exit the password modal without entering a password (or "invalid password") and the wallet loads as usual.

Acceptance Criteria

The wallet should not load if the correct password is not entered. Should not be able to by pass the password and have the wallet load.

Need By Date

No response

Screenshots/Mockups

No response

Ownership

• If my bounty needs engineering or needs product I have added the respective labels on the right
• As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

• Join our discord
• Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
• Please refer to this link for some basic info
• Please do not start work on this issue until you are approved in Gitcoin.

[NeOMakinG]

I'll take a look to this in the next few days 👍

[NeOMakinG]

@MBMaria

It's because any wallet never gets disconnected if you switch from a wallet to another, meaning that you don't have to enter your password in order to select your native wallet, until it timeout or you click "Disconnect"

We have 2 possibilities:

• Close the modal directly without prompting the password view in case the wallet is already initialized
• Disconnect the current wallet in case you click somewhere (for example, on click on the "Switch wallet" button?)

Could we talk about it and define the specs?

[DiggyDiggy2]

@MBMaria

It's because any wallet never gets disconnected if you switch from a wallet to another, meaning that you don't have to enter your password in order to select your native wallet, until it timeout or you click "Disconnect"

We have 2 possibilities:

• Close the modal directly without prompting the password view in case the wallet is already initialized
• Disconnect the current wallet in case you click somewhere (for example, on click on the "Switch wallet" button?)

Could we talk about it and define the specs?

I think that in switching wallet, we should disconnect the current one. isn't this the case for all the other wallets, when switching?

[NeOMakinG]

@DiggyDiggy2
When you switch from one wallet to another, the local state of the past wallet isn't cleared, meaning that you can switch to the past wallet without entering your passphrase again, I don't know if it's intended

Would it be fine if you click on Switch Wallet, and you end up on this view with the modal opened?

That would be the simplest way to fix that, the new action of switching wallets would be as simple as Disconnect everything, remove local state and storage, then open the connect wallet modal

Overwise, we could keep the local storage, (which would probably be unneeded anymore in case we clear it while switching?), but don't prompt the password modal while connecting to a wallet you previously connected to

[0xean]

@shapeshift/product - can someone take a look @NeOMakinG comment and respond so we can move forward? Ty

[DiggyDiggy2]

Since we don't really need the user to enter their password if they have already added a native wallet. We can go ahead and close the modal directly without prompting the password view in case the wallet is already initialized

[0xean]

@shapeshift/operations to take another pass to see if still valid.

[tshifty]

This ticket is still valid

[NeOMakinG]

I can take it, forget about it 😆

[Neverwas-dev]

I can recreate as well still