Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into removing console error findDOMNode is deprecated in StrictMode #31

Closed
bootsboogie opened this issue Sep 1, 2021 · 1 comment · Fixed by #466
Closed

Look into removing console error findDOMNode is deprecated in StrictMode #31

bootsboogie opened this issue Sep 1, 2021 · 1 comment · Fixed by #466
Labels
blocked good first issue Good for newcomers
Projects

Comments

@bootsboogie
Copy link
Contributor

bootsboogie commented Sep 1, 2021

Adding some context from a previously closed issue:


Update - it looks like there's a completely new v2 with a hook that will solve this issue. Please investigate updating to the v2.x+ version of this dep. https://github.com/airbnb/visx/releases


This is not likely to be fixed upstream in v1.x as it's a breaking change

airbnb/visx#737

there's also no way to conditionally disable strict mode

facebook/react#16362

Our current charts library is using deprecated methods and throwing console errors in the browser.

Update the library so we have a clean console for our first release.

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of withBoundingRects() which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here:

@bootsboogie bootsboogie created this issue from a note in Engineering (To do) Sep 1, 2021
@0xdef1cafe 0xdef1cafe added this to the Minimum Lovable Product milestone Sep 2, 2021
@0xdef1cafe 0xdef1cafe added the good first issue Good for newcomers label Sep 3, 2021
@jdambron
Copy link
Contributor

Upgrading all visx components to V2 seems quite transparent on my local version (I didn't see any regression, but I might have missed something). Also all tests are still passing after the upgrade.
Problem is, from my understanding, that the source issue is still not fixed in the V2. Therefore upgrading will not fix the console error.

Devs from visx are still deciding how they will implement it, from what I understood.
Maybe we should just flag this issue as blocked on our side, waiting for a fix on their side (as this is not exactly critical).

Engineering automation moved this from To do to Done Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked good first issue Good for newcomers
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants