Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memos to all the things TC #6679

Open
0xean opened this issue Apr 12, 2024 · 1 comment · May be fixed by #6753
Open

Add memos to all the things TC #6679

0xean opened this issue Apr 12, 2024 · 1 comment · May be fixed by #6753
Assignees
@gomesalexandre

Comments

@0xean
Copy link
Contributor

0xean commented Apr 12, 2024 •
edited

AC

  • ensure that all thorchain related tx's have memos with our affiliate code (even if free)
  • all evm transactions that aren't depositWithExpiry
  • goal is to be able to track all transactions and know they originated from our app
  • Monkey-patch lending memo to have an affiliate name (without an affiliate fee) until affiliate fees are supported upstream (i.e feat: lending affiliate bps #5813)
  • validate tc tx parsing doesn't break with all chains / tx types
@0xean
Copy link
Contributor Author

0xean commented Apr 15, 2024

  • be careful here, high risk prs...

@twblack88 twblack88 mentioned this issue Apr 17, 2024
Open
2 tasks
@gomesalexandre gomesalexandre self-assigned this Apr 25, 2024
This was referenced Apr 25, 2024
Merged
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
None yet
Projects
ShapeShift Dashboard
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: thorchain lending borrows useSendThorTx shapeshift/web
2 participants
@0xean @gomesalexandre