Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-actionable Li.Fi Multi-Hop trade quotes #6764

Closed
gomesalexandre opened this issue Apr 26, 2024 · 0 comments · Fixed by #6765 or #6791
Closed

Non-actionable Li.Fi Multi-Hop trade quotes #6764

gomesalexandre opened this issue Apr 26, 2024 · 0 comments · Fixed by #6765 or #6791
Assignees

Comments

@gomesalexandre
Copy link
Contributor

Overview

Currently while trying to swap MATIC to AVAX, multi-hop quotes are displayed.
However, we do not explicitly support multi-hop quotes yet.

As such, we have (wrong for multi-hop, correct for single hops) assumptions about the sell asset accountId.
These make it so we do wrong balance checks for Li.Fi multi-hops and mistakenly display "Not enough to cover gas" even when there is more than enough (see references section).

We should fix this so that these quotes are actually actionable and happy, or we filter these out.

References and additional details

Wrong accountId for multi-hop resulting in wrong balance checks:

// selects the account ID we're selling from for the other hops
// for posterity, every hop always sells from the same account as the first hop
export const selectSecondHopSellAccountId = selectFirstHopSellAccountId
export const selectLastHopSellAccountId = selectFirstHopSellAccountId

Acceptance Criteria

Either:

  • Multi-hop Li.Fi quotes are working
  • Multi-hop Li.Fi quotes are filtered out

Need By Date

No response

Screenshots/Mockups

image

Estimated effort

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant