Minor correction to Swift 2.3 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one -- I'll take a proper look at this later in the week and try and get it merged in ASAP :) Thanks for this. |
|
@shaps80 awesome. Let me know if I can do something when you check. |
|
don't forget that this PR should not be merge on |
|
Yep I understand :-) Shaps Sent from my iPhone
|
|
;) better safe than sorry ¯_(ツ)_/¯ thx |
|
@shaps80 congrats for your baby, let me know if you can review this.. ++ |
|
Apologies I had forgotten. Yes I can review just need to run it through some testing first.
Thanks for the contribution.
Shaps
…Sent from my iPhone
On 15 Dec 2016, at 12:41, Hugues Bernet-Rollande ***@***.***> wrote:
@shaps80 congrats for your baby, let me know if you can review this.. ++
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@shaps80 cool. keep me posted... |
|
👍🎅
…On Thu, Dec 22, 2016 at 9:23 PM Shaps M ***@***.***> wrote:
Merged #16 <#16>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ABcovyaqu7jrkr64AJ59togAHR7tdEyIks5rKtxAgaJpZM4KsdQL>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 2.3support branch.Please not it need also to be use with the
Swift 2.3branch ofInkKit. As this branch is not merge yet and you can't specify a git/branch in apodspec, you need to manually override it in yourPodfile...Also, same issue that for
InkKit, can't find a way to set base branch of the fork as it's not a branch but a tag... See this compare for the correct changes: 2.2.0...huguesbr:swift-2.3