Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment renamed to CustomSegment for solving naming conflict #63

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

Lukaz32
Copy link
Contributor

@Lukaz32 Lukaz32 commented Jul 5, 2018

Base Branch

Make sure you're currently pointing to the next release base branch. For example:

branch: release/5.1.0

If you're unsure, check the latest tag, it'll be a semantic version higher than that.

SwiftLint

Ensure SwiftLint hasn't reported any issues. Code styles must be adhered to.

README

Does the README need updating? Ensure anything relevant is updated there as well.

@shaps80
Copy link
Owner

shaps80 commented Jul 30, 2018

Can you elaborate what the issue is here? I'm not sure where the conflict is arising?
Also, not sure about the name CustomSegment. @Lukaz32

@Lukaz32
Copy link
Contributor Author

Lukaz32 commented Jul 30, 2018

There seems to be conflict with Apple's own UISegmentControl.Segment:

screen shot 2018-07-30 at 14 46 55

screen shot 2018-07-30 at 14 51 37

Do you have any suggestions for a better naming?
@shaps80

@shaps80
Copy link
Owner

shaps80 commented Jul 30, 2018

Oh interesting. I hadn’t seen that yet. Thanks for posting a screenshot.

Ok so what about one of these @Lukaz32?

SegmentDescriptor
SegmentItem
SegmentElement

Sent with GitHawk

@Lukaz32
Copy link
Contributor Author

Lukaz32 commented Aug 2, 2018

SegmentItem seems much more suitable. :)

@shaps80 shaps80 merged commit d2b5140 into shaps80:master Aug 2, 2018
@shaps80
Copy link
Owner

shaps80 commented Aug 2, 2018

Thanks for the PR. All merged for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants