added some fixes from @tarr11 to codemirror integration #119
+106
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more thing, you just recompiled the webclient right ( |
|
@automata So can you add the changes you made to https://github.com/josephg/ShareJS/blob/master/src/client/cm.coffee ? This pull request only has cm.js which gets overwritten every time someone runs |
| editor.setOption('onChange', null); | ||
| return delete this.detach_cm; | ||
| doc.detach_codemirror = function () { | ||
| editorDoc.removeListener('change', editorListener); |
There was a problem hiding this comment.
This should be editorDoc.setOption('onChange', null) for codemirror 2+
|
@automata I would love to merge this but in its current state I can't. Any chance you could change the pull request like discussed in the comments? Thanks! |
|
@automata ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added suggested fixes from @tarr11: https://github.com/tarr11/codeshare/
the old webclient/cm.js didn't works properly. this one is working the same way the ace backend (at least in my tests).
I also changed examples/cm/index.html. so we can test this on the bin/exampleserver and then http://localhost:8000/cm
fix-cm branch.
thanks about your incredible work on sharejs!