Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShimmerRecyclerView always show one item when layout manager equals "linear_horizontal" #30

Closed
kaiyan910 opened this issue Mar 19, 2018 · 4 comments

Comments

@kaiyan910
Copy link

kaiyan910 commented Mar 19, 2018

When applying "linear_horizontal" to the recycleview it always shows one 1 item.
No matter what value I set to "shimmer_demo_child_count".

I think the problem is viewholder_shimmer.xml, as it uses match_parent for width showing a single item will occupy the full width and not be able to show the second item for horizontal recyclerview.

The problem solved when I overrided viewholder_shimmer.xml and set it wrap_content for width.

@veghtomi
Copy link
Collaborator

@kaiyan910 Thanks for reporting the issue, it will be fixed soon!

@veghtomi
Copy link
Collaborator

@kaiyan910 Issue is fixed. Probably next week going to be released by @sharish

@KarmatechMediaworks
Copy link

has the version number been changed, can you let me know the latest version number

@veghtomi
Copy link
Collaborator

veghtomi commented Apr 9, 2018

@KarmatechMediaworks the new release it out! Try it.

@veghtomi veghtomi closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants