Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --panels=auto the new default? #182

Closed
sharkdp opened this issue Dec 5, 2022 · 3 comments
Closed

Make --panels=auto the new default? #182

sharkdp opened this issue Dec 5, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sharkdp
Copy link
Owner

sharkdp commented Dec 5, 2022

The new --panels=auto option is really nice. Should we make it the new default (instead of --panels=2)?

If not (maybe because it is weird on very wide terminals), should we at least use --panels=1 automatically if the terminal width is too small to display the default two panels?

FYI @sharifhsn

@sharkdp sharkdp added enhancement New feature or request good first issue Good for newcomers labels Dec 5, 2022
@sharifhsn
Copy link
Contributor

I think the second option makes more sense. It's expected behavior for hex viewers to print 16 bytes at a time, so deviating from that for the default would be unwise. But we can still make that calculation so that it doesn't wrap lines on the default 2 panels.

@sharkdp
Copy link
Owner Author

sharkdp commented Dec 7, 2022

Agreed!

@sharkdp sharkdp self-assigned this Dec 7, 2022
@sharkdp sharkdp closed this as completed in 437a15f Dec 7, 2022
@sharkdp
Copy link
Owner Author

sharkdp commented Dec 7, 2022

Implemented. This is actually pretty helpful when using --base=binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants