Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM version: developer instructions and CI checks #231

Closed
sharkdp opened this issue Nov 6, 2023 · 3 comments
Closed

WASM version: developer instructions and CI checks #231

sharkdp opened this issue Nov 6, 2023 · 3 comments
Labels
code-maintenance documentation

Comments

@sharkdp
Copy link
Owner

sharkdp commented Nov 6, 2023

We should write a better documentation on how to build/run the web version of Numbat locally.

Also, we should probably run wasm-pack in the CI pipeline.
@eminence
Copy link
Contributor

eminence commented Nov 6, 2023

I was able to pretty easily get the web version running locally by following the README, so we already have a good foundation.

@sharkdp
Copy link
Owner Author

sharkdp commented Dec 5, 2023

I used https://www.furidamu.org/blog/2020/07/10/rust-webassembly-in-the-browser/ for the blog post (https://numbat.dev/articles/intro.html) and it worked quite well. Maybe we can do this for the main website as well and get rid of all the NPM stuff.

@sharkdp
Copy link
Owner Author

sharkdp commented Dec 19, 2023 •
edited
Loading

This is now significantly easier since #280. No need for Node/NPM anymore. The WASM version is now also built & tested (in a headless browser) in CI.

@sharkdp sharkdp closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-maintenance documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eminence @sharkdp