read_all attribute

[Ayrx]

Currently there are the count, bytes_read, bits_read and until attributes you can apply to a Vec to tell deku how much to read.

A read_all (name undecided) attribute that tells deku to parse till the end of the input would be very handy and could be used to avoid some ugly math in the bytes_read attribute.

[dullbananas]

You don't need bytes_read

#[deku(until = "|_| false")]

Edit: actually that doesn't work because it tries to read beyond the last byte and throws an error. Instead you need bits_read = "deku::rest.len()". I think read_all would be better.

[mmun]

It seems like bits_read = "deku::rest.len()" mostly works except that it cannot handle an empty vec.

[duskmoon314]

The new implementation based on reader no longer supports deku::rest. Currently, I cannot find a way to read all remaining bytes to a Vec.

I think adding a read_all attribute lets reader_vec_with_predicate check reader.end() instead of predicate can solve the problem. I hope @wcampbell0x2a can share some ideas.

[wcampbell0x2a]

Hey @duskmoon314, does #387 solve your use case?