Fix floating point errors - Achieve Zero tolerance for these errors #11
Assignees
Milestone
Comments
sharma-subendra-kr
modified the milestones:
v1.0.0-beta.0,
v1.0.0.0-beta.1,
v1.0.0-beta.1,
v1.0.0-beta.2
sharma-subendra-kr
modified the milestones:
v1.0.0-beta.2,
v1.0.0.0-beta.3,
v1.0.0-beta.3,
v1.0.0-beta.4
sharma-subendra-kr
added a commit
that referenced
this issue
Nov 6, 2020
…raction already done, doing twice so removed
sharma-subendra-kr
added a commit
that referenced
this issue
Nov 7, 2020
sharma-subendra-kr
added a commit
that referenced
this issue
Nov 15, 2020
* bug fix: removed unnecessary looping over to change dom; removeComplete was getting triggered after losing reference to the correct DOM node * bug fix: margin error while resizing and moving * dist update * Issue #42: fixed adding at disallowed places; refactored: mergeRects function in rectUitls; commented debug imports * rectUtils figures fix * cross hair element added; rectUtils: bugfix * update * prettier conf update * update * Working new latching feature on move, needs some more work * update * update * stack and it changed to only once instances * removed redundant code * update * request animation frame * update * performance: added helper to find * getResizeWSItemsDetail: cleanup; others: cleanup * itemInteractionUtils: cleanup * rectUtils: cleanup * update * update * arrange tweak: try to fix to a location nearest to the original location * clean up * messages: message added for latching * message: updated; latching: move latch threshold changed * uppdate * arrangeUtils: optimization for items very far apart in terms of height (this is commented as this has some bugs); itemInteractionUtils: Limit height of an item; * logs removed * removed comment * update * update * dist update * update * fixed: autoarraning on empty objects * dist update * css changes * update * dist update * bug fix * update * update * dist update * resize bug: resize with out demo bug fix; animation frame improvement: setTimeout before long running tasks that take 1-50+ms * optimization: take top y and bottom y of moved item if the moved item is very far apart from original position i.e. greater than the width of the screen, cuz height of screen is smaller so width is taken; deprecated event.which removed * redundant imports removed; mouse down timer reduced * redundant/code that doesnt work removed * Issue #11: some fix but have to check more; bug fix: arrange.js, subtraction already done, doing twice so removed * Issue: #11: some floating point errors handled while merging rects * removed comments * Issue #47: latch bottom added * removed comments * Issue #46: width latching on tr and br only, this should do it maybe dont require on tl and bl * jest added * tests * adj and overlapping keys have been removed * if statement removed, cuz this will never be included in min bundle * optimization
|
make resize/move digits round to 3 when respective actions done. try this out. anything done at calculation time crashes everything |
|
try rounding to .250, .500, .750, .000 |
|
rounding original dimensions and adding the margin seems to do the job |
sharma-subendra-kr
changed the title
|
All above fixes were done at haste. Refer them to see what was tried earlier to save time. |
sharma-subendra-kr
added
enhancement
|
seems fixed in version release-1.0.0-beta.15 which is private |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fix unexpected behavior while moving/resizing items due to floating point errors.
The text was updated successfully, but these errors were encountered: