Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch ripple is broken #21

Closed
sharma-subendra-kr opened this issue Jul 20, 2020 · 1 comment
Closed

Touch ripple is broken #21

sharma-subendra-kr opened this issue Jul 20, 2020 · 1 comment
Assignees
Labels
bug Something isn't working Done Issues Resolved
Milestone

Comments

@sharma-subendra-kr
Copy link
Owner

Touch ripple is broken

@sharma-subendra-kr sharma-subendra-kr added the bug Something isn't working label Jul 20, 2020
@sharma-subendra-kr sharma-subendra-kr added this to the v1.0.0-beta.0 milestone Jul 20, 2020
@sharma-subendra-kr sharma-subendra-kr self-assigned this Jul 20, 2020
@sharma-subendra-kr sharma-subendra-kr added the IN PROGRESS Issues that are in progress label Jul 20, 2020
@sharma-subendra-kr sharma-subendra-kr added Done Issues Resolved and removed IN PROGRESS Issues that are in progress labels Jul 20, 2020
@sharma-subendra-kr
Copy link
Owner Author

commit 11a21e1

sharma-subendra-kr added a commit that referenced this issue Jul 25, 2020
* move to es6 file structure arrangements

* broke event handlers, essentials and some utils code and moved to other files

* moved logic codes into different files

* removed outfiles from git status by removing git cached

* constants removed from this and added to a seperate file

* options, positionData, initialPositionData, initialGridData, callbacks made as importable objects

* moved element variables to a different file

* variables relating to events initialized in package level, Padding moved to private constants

* serializedPositionData seperated, isMobile seperated, this. removed from getMarginAtPoint, removed .call() from calc/calcUtils, many but not all this. removed from calc.calcUtils

* init moved to initializers, render pseudos moved renderers, Width_scale_factor moved to private constants, elementId and pseudoElementId id moved to variables

* render and renderItems moved to renderers, binded function variables removed, event initializers moved to eventHandlerLib, add or remove items moved to renderers

* removed .call

* issue #2 : isMobile will check a supplied function if exists first

* license update

* written rect overlap and rect subtraction code - NOT TESTED

* subtract rect fix - NOT TESTED

* subtract rect fix - TESTED

* clean up

* renamed _calcUtils to rectUtils

* item interaction update, check if point is inside rectangle

* update

* update

* update - NOTHING TESTED

* update

* update

* find free rects done, debug print free rects added

* finding free space fix, finding adjacent rects fix

* update

* update

* update

* update

* merge rects tl working

* update

* mergeRects - TESTED

* merging code

* minor update

* update - NOT TESTED

* told merged's adjacent that mergedd is adjacent to them

* moved to eslint; mergeRects merging overlapped also

* mergeFreeRects working

* free rects to chack again for their turn

* ref of adjacent was not being set since break was happeining after top's adjacent was set, moved the setting of ref of adjacent before top

* find overlapped added; finding adjacent by x coordinates through it commented, so far not useful, debug tools upgraded

* update

* config changes; sumblime config file added; vscode config file added

* update

* rect: bugfix; update

* update

* update

* update

* debug tools enhancements

* update

* debug tools enhancements

* update

* update

* clean up after a affected item has found a place

* update

* removed comments and console.log; renamed variable

* code cleanup

* cleanup

* update

* update

* cleanup

* update

* update

* update

* update

* debug tools enhancements

* Issue: #6: removing code to delete links after merge; 'else if' condition is just some optimization; code cleanup

* linter, prettier ignore update; code cleanup

* event handlers refactor

* update

* update

* update

* update

* optimization to mergeFreeRects Algorithm

* Issue: #6 most stable mergeFreeRects till now 14th July 2020

* mergeFreeRects update with more stable version

* mergeFreeRect optimization; debug tools enhancement

* debug tools fix

* Issue: #6: merging of partial overlapping rects which give 2 rects as output was causing an infinite loop; Debug tools enhancement; extra debug code for reference which will be removed later

* cleanup

* plugged in resize

* css updates

* css update

* resize new algo; bug fix for findOverlapped: if a smaller didn't completely overlap a rect in consideration and then a a bigger rect overlapped the rect in consideration then the first smaller didn't delete its link to the rect in consideration but the second one which completely overlapped the rect in consideration did remove its link

* cleanup

* findOverlapping: theoritical solution done

* final results overlapping: when rects overlapping the pm rect were sutracted, its overlapping rects were not told that it had been subtracted; debug tools enhancement; clean up

* mergeFreeRects Optimization: discard duplicates and completely overlapped

* fixed arrange starting positions

* demo outline

* removed comments, cleanup

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* Issue #4: update

* undefined top or bottom ws error fix

* Issue #20: cut space is fixed

* Issue #18: fixed latch css

* upadte: bug fixes

* Issue #21: fixed touch ripple

* update

* update

* moved DEFINED_MIN_HEIGHT_AND_WIDTH to private constants

* Issue #23: added pseudo element to show height and width while resizing

* Issue #23: all done

* resize and move callbacks updated

* Issue #13: added LATCH_MOVED_ITEM flag

* Issue #24: update

* bug fix update

* Issue #24: update

* Issue #24: update

* Issue #9: fixed

* Issue #3: fixed

* Issue #22: enhanced

* Issue #25: enhanced

* update

* css class name change

* Issue #19: update

* Issue #19: fixed

* Issue #12: enhanced

* debug tools update

* Issue #27: fixed

* update: bug fix

* API changes

* bug in cutspace fixed

* license text update

* build tools update

* bug fix

* bug fix: height and width in style should be string ending with px

* dist update

* cleanup

* dist update

* typo

* dist update

* typo

* bug fix: use Defined min height and width if no params are present

* dist update

* license icon css update

* added missing code

* added render item content through plugin

* support react dom to render: react dom doesnt render into unmounted elements

* dist update

* removing innerHTML for type string and node only

* default options added

* bug fix

* added remove plugin; also added currenttarget for move and resize check

* allow to render nothing

* mistake

* fix: missing remove code

* build update

* dist update

* build update

* update

* build update

* build file

* MASSIVE CLEANUP

* using tabs with 2 space distance

* inserted tabs instead of spaces

* webpack config update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Done Issues Resolved
Projects
None yet
Development

No branches or pull requests

1 participant