Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove display none #39

Closed
sharma-subendra-kr opened this issue Aug 31, 2020 · 1 comment
Closed

remove display none #39

sharma-subendra-kr opened this issue Aug 31, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sharma-subendra-kr
Copy link
Owner

remove display none for pseudo Items and where ever possible and replace it with other solutions

@sharma-subendra-kr sharma-subendra-kr added the bug Something isn't working label Aug 31, 2020
@sharma-subendra-kr sharma-subendra-kr added this to the v1.0.0-beta.2 milestone Aug 31, 2020
@sharma-subendra-kr sharma-subendra-kr self-assigned this Aug 31, 2020
@sharma-subendra-kr
Copy link
Owner Author

moving to 1.0.0-beta-3 cuz, I want to measure the performance with 1000 items

@sharma-subendra-kr sharma-subendra-kr moved this from To do to In progress in v1.0.0-beta.3 Apr 12, 2021
sharma-subendra-kr added a commit that referenced this issue Apr 13, 2021
sharma-subendra-kr added a commit that referenced this issue Apr 13, 2021
v1.0.0-beta.3 automation moved this from In progress to Done Apr 13, 2021
sharma-subendra-kr added a commit that referenced this issue Apr 13, 2021
* Issue #41: done; refactor

* Issue #75: done

* Issue #39: partial fix

* Issue #39: partial

* Issue #39: remove display none

* updating license z index
sharma-subendra-kr added a commit that referenced this issue May 8, 2021
* update

* arrange largest hypotenus first

* this is more optimized

* Release 1.0.0 beta.3 wip 2.1 (#71)

* rtreejs version update

* sanitization update

* fix: hopefully floating point errors fix

* hmmm only this much should do it

* Release 1.0.0 beta.3 wip 2.2 (#73)

* subtractRect to follow x1, x2, y1, y2 format

* merge rect compliant to x1, x2, y1, y2

* helper functions compliant to x1 x2 y1 y2

* rectUtils, helper functions compliant to x1, x2, y1, y2

* compliance

* removing getItemDimenWithMargin

* compliance update

* compliance

* rtreejs update

* compliance

* update

* test  cases

* update

* test cases

* test update

* mergeRect: bug fix; mergerect: test cases

* reorder

* mergeRect: bug i think; mergeRect: test cases

* mergeRects: test cases

* mergeRects: bug fix; mergeRects: test cases

* mergeRects: test cases

* some bug fixes

* update

* bugfix: arrangeCore; compliance

* bug fix

* some more bug fixes

* this prevents moving all items below combined workspace at each iteration

* update

* bugfix: not using margin here will cause an item to be in both bottom workspace and below bottom workspace hence shifting twice

* fixing resize

* bugfix: wasnt taking the upaded width and height

* bugfix: edge cases

* bugfix: arrange from height

* auto arrange fix

* bugfix

* bugfix: top and left

* scroll added on add item via button

* Release 1.0.0 beta.3 wip 2.3 (#77)

* improvement: move to new merge algo

* logging number of rectangles processed

* Issue #74: fixed

* seems not needed

* Release 1.0.0 beta.3 wip 2.4 (#78)

* update

* rendering items on moves

* update

* bugfix: missing px

* Issue #63: calculation using factor; defined min height and width checks added

* shrink to fit flag added

* massive clean up

* Release 1.0.0 beta.3 wip 2.5 (#81)

* first undo redo working feature

* enhancement: undo redo working and optimized

* Release 1.0.0 beta.3 wip 2.6 (#82)

* update

* update

* update

* left resize tool 1st working version

* touch resize left fix

* z-index fix

* resize threshold distance reduced

* missing args

* update

* bugfix: not allowing items-in-combinedworkspace to be in items-in-bottom-workspace or items-below-bottom-workspace

* Release 1.0.0 beta.3 wip 2.7 (#83)

* Issue #48: supposedly fixed

* event, scroll, touch, etc code REFACTOR

* slowing down scroll

* flags added

* constants used

* Issue #79: done; Issue #80: done

* Release 1.0.0 beta.3 wip 2.8 (#84)

* Issue #41: done; refactor

* Issue #75: done

* Issue #39: partial fix

* Issue #39: partial

* Issue #39: remove display none

* updating license z index

* Release 1.0.0 beta.3 wip 2.9 (#85)

* Issue #76: move to resize observer

* Issue #76: done

* Issue #76: resize observer

* Issue #76: resizeObserver polyfill added

* Release 1.0.0 beta.3 wip 2.10 (#86)

* isMobile fix

* fix: firefox event object getting reset

* Release 1.0.0 beta.3 wip 2.11 (#87)

* setup

* file change

* intersection observer logic

* first working version intersection observer

* this is smoother

* update

* update

* io hopefully all good

* bugfix

* bugfix

* onScroll event added

* bugfix

* removed unnecessary code

* removed unnecessary imports

* update

* Release 1.0.0 beta.3 wip 2.12 (#90)

* mobile intersection observer

* bugfix

* getLogMessage added

* scrollTo behaviour auto on prepend
sharma-subendra-kr added a commit that referenced this issue Jun 2, 2021
* rtreejs added; comments refactor

* clear terminal added; build.sh added; rtreejs added

* sweepline top and bottom move to rtrees

* removed  unused imports

* arrange move to rtree

* update

* sort fix

* rtree update

* bug fix

* refactor; rect removed from data

* update

* RECTUTILS refactor and optimizations

* removed unused function areRectsAdjacent

* removed doRectsOnlyTouch with threshold; refactored doRectsOverlap

* resize and arrange from height compliant to rtrees

* rtree update

* optimization

* optimiation

* refactor

* rtree container added

* rtree debug tools

* rtree update

* rtree update

* rtree update

* rtree update

* rtreejs update

* rtreejs update

* sanitize functions added, incomplete

* minor

* bugfix: doRectsOverlap; sanitized margin anddefined  min height and width

* sweepline algo change for top and bottom find

* update

* logic to select best pos changed

* debug.js compliant to rtree

* rtreejs update

* npm update; bug fix

* update

* Release 1.0.0 beta.3 wip 2 (#91)

* update

* arrange largest hypotenus first

* this is more optimized

* Release 1.0.0 beta.3 wip 2.1 (#71)

* rtreejs version update

* sanitization update

* fix: hopefully floating point errors fix

* hmmm only this much should do it

* Release 1.0.0 beta.3 wip 2.2 (#73)

* subtractRect to follow x1, x2, y1, y2 format

* merge rect compliant to x1, x2, y1, y2

* helper functions compliant to x1 x2 y1 y2

* rectUtils, helper functions compliant to x1, x2, y1, y2

* compliance

* removing getItemDimenWithMargin

* compliance update

* compliance

* rtreejs update

* compliance

* update

* test  cases

* update

* test cases

* test update

* mergeRect: bug fix; mergerect: test cases

* reorder

* mergeRect: bug i think; mergeRect: test cases

* mergeRects: test cases

* mergeRects: bug fix; mergeRects: test cases

* mergeRects: test cases

* some bug fixes

* update

* bugfix: arrangeCore; compliance

* bug fix

* some more bug fixes

* this prevents moving all items below combined workspace at each iteration

* update

* bugfix: not using margin here will cause an item to be in both bottom workspace and below bottom workspace hence shifting twice

* fixing resize

* bugfix: wasnt taking the upaded width and height

* bugfix: edge cases

* bugfix: arrange from height

* auto arrange fix

* bugfix

* bugfix: top and left

* scroll added on add item via button

* Release 1.0.0 beta.3 wip 2.3 (#77)

* improvement: move to new merge algo

* logging number of rectangles processed

* Issue #74: fixed

* seems not needed

* Release 1.0.0 beta.3 wip 2.4 (#78)

* update

* rendering items on moves

* update

* bugfix: missing px

* Issue #63: calculation using factor; defined min height and width checks added

* shrink to fit flag added

* massive clean up

* Release 1.0.0 beta.3 wip 2.5 (#81)

* first undo redo working feature

* enhancement: undo redo working and optimized

* Release 1.0.0 beta.3 wip 2.6 (#82)

* update

* update

* update

* left resize tool 1st working version

* touch resize left fix

* z-index fix

* resize threshold distance reduced

* missing args

* update

* bugfix: not allowing items-in-combinedworkspace to be in items-in-bottom-workspace or items-below-bottom-workspace

* Release 1.0.0 beta.3 wip 2.7 (#83)

* Issue #48: supposedly fixed

* event, scroll, touch, etc code REFACTOR

* slowing down scroll

* flags added

* constants used

* Issue #79: done; Issue #80: done

* Release 1.0.0 beta.3 wip 2.8 (#84)

* Issue #41: done; refactor

* Issue #75: done

* Issue #39: partial fix

* Issue #39: partial

* Issue #39: remove display none

* updating license z index

* Release 1.0.0 beta.3 wip 2.9 (#85)

* Issue #76: move to resize observer

* Issue #76: done

* Issue #76: resize observer

* Issue #76: resizeObserver polyfill added

* Release 1.0.0 beta.3 wip 2.10 (#86)

* isMobile fix

* fix: firefox event object getting reset

* Release 1.0.0 beta.3 wip 2.11 (#87)

* setup

* file change

* intersection observer logic

* first working version intersection observer

* this is smoother

* update

* update

* io hopefully all good

* bugfix

* bugfix

* onScroll event added

* bugfix

* removed unnecessary code

* removed unnecessary imports

* update

* Release 1.0.0 beta.3 wip 2.12 (#90)

* mobile intersection observer

* bugfix

* getLogMessage added

* scrollTo behaviour auto on prepend

* update

* update

* udpate

* update

* dist upadte

* udpate

* update

* optimization by filtering

* dist update

* optimization fix

* dist update

* intersection observer fix; cursor change

* update

* reverting the fix intersection observer as it creates more problems

* dist update

* bug fix

* update

* bugfix: removing the wrong index from renderedItems array

* update

* bugfix: updating indices

* dist update

* bugfix: index coming as string so parsing as int

* dist update

* bugfix: mobile scroll io bottom helper position not getting updated when item is deleted

* bugfix: rendering serialized items when an item is deleted

* bugfix: remove item mobile devices

* making files same as demo branch

* dist update

* bugfix: removeComplete being called before splice of pd happens

* dist update

* Update README.md

release-1.0.0-beta.3 readme update

* license updated, template, one file only

* license: date changed, intro changed, debug imports removed

* Rights changed to rights

* dist update

* package update

* installation added

* added some text

* some text  update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant