Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set INTERFACE_COMPILE_DEFINITIONS of imported gflags library targets to define GFLAGS_DLL_DECL #78

Open
GoogleCodeExporter opened this issue Mar 13, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

CMake's 
[http://www.cmake.org/cmake/help/v2.8.12/cmake.html#prop_tgt:INTERFACE_COMPILE_D
EFINITIONS INTERFACE_COMPILE_DEFINITIONS] property on the imported targets can 
be used to specify the proper definition of GFLAGS_DLL_DECL if both shared and 
static libraries were build. In this case, both libraries require the inclusion 
of the same public header files, but with different GFLAGS_DLL_DECL in case of 
the VS compiler.

Original issue reported on code.google.com by andreas....@gmail.com on 25 Mar 2014 at 3:34

@GoogleCodeExporter
Copy link
Author

Original comment by andreas....@gmail.com on 25 Mar 2014 at 3:38

  • Changed title: Set INTERFACE_COMPILE_DEFINITIONS of imported gflags library targets to define GFLAGS_DLL_DECL

@GoogleCodeExporter
Copy link
Author

Postponing this change which requires a bit more thorough investigation of how 
this CMake setting is used, while the gflags 2.1.1 release which fixes the 
configuration of gflags_declare.h of gflags 2.1.0 were more urgent.

Original comment by andreas....@gmail.com on 30 Mar 2014 at 2:52

  • Added labels: Milestone-v2.2
  • Removed labels: Milestone-v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant