Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lhp calculation error #220

Open
kelliecook opened this issue Sep 2, 2021 · 0 comments
Open

lhp calculation error #220

kelliecook opened this issue Sep 2, 2021 · 0 comments

Comments

@kelliecook
Copy link

Hello,

I think there may be an error in the lhp parameter calculation in params. In Johnson and Sugden 2014, when Term A and Term B are both negative, the LHP should be set to 0. However in the current code:

    if term_a < 0:
        term_a = 0

and further,

    if term_b < 0:
        term_b = 0

I think it should be:

  if term_a and term_b < 0:
     LHP = 0

Otherwise, setting either Term A or B to 0 separately will consistently result in a value of 5, since we are multiplying by a negative number and then adding 5.

Hope that makes sense! And thanks for creating such a great program!

Best wishes,
Kellie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant