Fix selection behavior for polymer 1.0 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,7 +67,7 @@ end | |||
|
|
|||
| render(ps::Pages, state) = | |||
| Elem("iron-pages", | |||
| map(t -> Elem("section", render(t, state)), ps.pages.tiles), | |||
| map(t -> Elem("div", render(t, state)), ps.pages.tiles), | |||
There was a problem hiding this comment.
It is not required, the current docs for iron-pages indicate that these should be divs. I'd assume that selection would work, but I went with consistency.
|
I believe you can use the reflect to attribute on the polymer element to lift the value. But your solution looks good. |
|
having properties and attributes mean different things pretty messy. We will find a nice way to fix #72. But for now, could you update the PR? |
|
Sure will. Thanks for looking. |
Closed
shashi
added a commit
that referenced
this pull request
Sep 3, 2015
Fix selection behavior for polymer 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polymer 1.0 defines pages as div elements in current examples. Virtual patch of attribute boolean values fails with sneaky dom and results in an always true value. This breaks the tabbed pages example.