Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot does not recognize fast name change #12

Closed
jbertino opened this issue Apr 22, 2014 · 3 comments
Closed

Bot does not recognize fast name change #12

jbertino opened this issue Apr 22, 2014 · 3 comments

Comments

@jbertino
Copy link
Contributor

If someone joins the channel and then changes their name before the minute of silence is up the bot will use the original name to greet them.

Example of the issue is at: http://bpaste.net/show/222579/

@shaunagm shaunagm added the bug label May 6, 2014
@shaunagm
Copy link
Owner

shaunagm commented May 9, 2014

To fix this, someone needs to:

a) determine the IRC syntax for when someone changes their nick, and have the main loop check for it
b) check if a person changing their nick is a "newcomer"
c) if a newcomer, update the newcomer object with the new nick

It's not entirely clear to me whether the bot should save just the new nick, or both.

@amitt001
Copy link

amitt001 commented Jul 7, 2014

Hi shaunagm
I'm want to fix this this bug.

@shaunagm shaunagm added the has PR label Jul 7, 2014
@shaunagm
Copy link
Owner

shaunagm commented Jul 7, 2014

I'm glad you left this comment! This has already been fixed in a PR:
#21 but I haven't merged it
yet/closed the issue. I've added a "has PR" label to issues have PRs
submitted, and hopefully I'll be able to merge them soon. That way you can
more easily find one of the remaining bugs to fix.

Thanks for your interest in WelcomeBot! :)

On Jul 7, 2014 4:20 AM, "Amit Tripathi" notifications@github.com wrote:

Hi shaunagm
I'm want to fix this this bug.


Reply to this email directly or view it on GitHub
#12 (comment).

shaunagm added a commit that referenced this issue Sep 17, 2014
Fix for issue #12 : Update upon name change prior to being greeted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants