Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: oxocarbon can only be set as color scheme once #38

Closed
chrisgrieser opened this issue Dec 10, 2022 · 3 comments · Fixed by #42
Closed

Bug: oxocarbon can only be set as color scheme once #38

chrisgrieser opened this issue Dec 10, 2022 · 3 comments · Fixed by #42

Comments

@chrisgrieser
Copy link

chrisgrieser commented Dec 10, 2022 •
edited

To reproduce:

  1. remove everything that sets a colorscheme from your neovim config
  2. run :colorscheme oxocarbon
  3. run :colorscheme blue (or any other colorscheme)
  4. run :colorscheme oxocarbon again

The first two colorscheme will work, but setting oxocarbon as colorscheme a second time does not work. This is relevant for some use cases where you want to change your colorscheme during runtime, for example styler or auto-dark-mode.

I checked, oxocarbon seems to be the only theme that has this issue, other themes, builtin or from the community, do not have this problem.
@cvigilv
Copy link

cvigilv commented Dec 18, 2022

I second this, find attached a gif showcasing the problem
Peek 2022-12-18 15-23

@ethanmsl
Copy link

same, no issues with other default or added colorschemes
nvim v0.8.1
macOS

nothing coming up from :checkhealth

@boydkelly
Copy link
Contributor

Thinking this is the same issue. my startup theme is set to nightfly, and although oxocarbon is loaded as shown below with Lazy.nvim, I can't switch to it at all.

Running L ● oxocarbon.nvim 0.39ms  start
~ dir /var/home/bkelly/.local/share/nvim/lazy/oxocarbon.nvim
~ url https://github.com/nyoom-engineering/oxocarbon.nvim
~ branch main
~ commit e5038beazy but showing loaded at start, but oxocarbon theme not available.

running neovim nightly neovim-0.9.0~dev.557.g94ce25065-500.fc37.x86_64

rktjmp added a commit to rktjmp/oxocarbon.nvim that referenced this issue Jan 3, 2023
@rktjmp
(code) clear lua module cache in colors/oxocarbon.lua
1a338b3 
Lua modules are cached after require, which prevents clean
re-application of oxocarbon when swapping *back*, after swapping to
another theme. By always un-caching the module we force a reload each
time.

Fixes nyoom-engineering#38
@rktjmp rktjmp mentioned this issue Jan 3, 2023
Merged
@chrisgrieser chrisgrieser mentioned this issue Jan 6, 2023
Closed
@chrisgrieser chrisgrieser mentioned this issue Jan 15, 2023
Open
boydkelly pushed a commit to boydkelly/oxocarbon.nvim that referenced this issue Mar 27, 2023
@rktjmp @boydkelly
(code) clear lua module cache in colors/oxocarbon.lua
359fb4a 
Lua modules are cached after require, which prevents clean
re-application of oxocarbon when swapping *back*, after swapping to
another theme. By always un-caching the module we force a reload each
time.

Fixes nyoom-engineering#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(code) clear lua module cache in colors/oxocarbon.lua rktjmp/oxocarbon.nvim
4 participants
@boydkelly @cvigilv @ethanmsl @chrisgrieser