Rankings Issues

[Technoblazed]

• After getting a WR and doing !rank, the client remains unranked.
  • Does not receive a rank and has no chat tags, nor clantags.
  • I think something is inverted: https://gyazo.com/8e643c1531fd77cae4547869d7a9a777
• First record set on a map is receiving 49.99 points.
• 49.993 + 24.491 = 73.26? Nope D: Actually is 74.484, I know it's only 1, but would annoy someone else.

[shavitush]

After getting a WR and doing !rank, the client remains unranked.

weird, i'll take a look

First record set on a map is receiving 49.99 points.

sourcemod's rounding ughhh, i'll fix it though

49.993 + 24.491 = 73.26? Nope D: Actually is 74.484, I know it's only 1, but would annoy someone else.

49.993 = 100% = 49.993
24.491 = 97% (dropped by 3% in weighting) = 23.75627

I thought you knew we use a weighting system :/

[shavitush]

anyways ok this new ranking method is a really big mess, i'll rewrite it all this weeksoon and try to make it actually make sense

[Technoblazed]

Is anybody currently using the ranking system, if so, what are the outlying issues with itself and chat? Like, will it sort of work?

[shavitush]

i think you won't gain points and rank calculation will be broken. chat itself is fine afaik

[Technoblazed]

But the link between shavit-chat <-> shavit-ranking is that they both rely on each other correct?

[shavitush]

shavit-chat relies on shavit-rankings, but not vice versa

[Nickelony]

Here's a working version of shavit-rankings made by zipcore: https://pastebin.com/raw/iuz6bgky

He tried to fix the plugin just so it works, but the rankings are killing the mysql database so it's unusable, but maybe this can help you in the future.

[shavitush]

I'll look into it soon and try optimizing the plugin, thanks.

[Nickelony]

oh and this in shavit-core:

char[] sQuery = new char[512];
	FormatEx(sQuery, 512, "REPLACE INTO %susers (auth, name, country, ip, lastlogin) VALUES ('%s', '%s', '%s', '%s', %d);", gS_MySQLPrefix, sAuthID3, sEscapedName, sCountry, sIP, GetTime());

replace with:

char[] sQuery = new char[2048];
	
	if (gB_MySQL)
		FormatEx(sQuery, 2048, "INSERT INTO %susers (auth, name, country, ip, lastlogin) VALUES ('%s', '%s', '%s', '%s', %d) ON DUPLICATE KEY UPDATE name = '%s' , country = '%s', ip = '%s', lastlogin = %d;", gS_MySQLPrefix, sAuthID3, sEscapedName, sCountry, sIP, GetTime(), sEscapedName, sCountry, sIP, GetTime());
	else FormatEx(sQuery, 2048, "REPLACE INTO %susers (auth, name, country, ip, lastlogin) VALUES ('%s', '%s', '%s', '%s', %d);", gS_MySQLPrefix, sAuthID3, sEscapedName, sCountry, sIP, GetTime());

and this

FormatEx(sQuery, 512, "CREATE TABLE IF NOT EXISTS `%susers` (`auth` VARCHAR(32) NOT NULL, `name` VARCHAR(32), `country` VARCHAR(128), `ip` VARCHAR(64), `lastlogin` %s NOT NULL DEFAULT -1, `points` FLOAT NOT NULL DEFAULT 0, PRIMARY KEY (`auth`));", gS_MySQLPrefix, gB_MySQL? "INT":"INTEGER");

with this:

FormatEx(sQuery, 512, "CREATE TABLE IF NOT EXISTS `%susers` (`auth` VARCHAR(32) NOT NULL, `name` VARCHAR(32), `country` VARCHAR(128), `ip` VARCHAR(64), `lastlogin` %s NOT NULL DEFAULT -1, `points` FLOAT NOT NULL DEFAULT 0, PRIMARY KEY (`auth`)%s);", gS_MySQLPrefix, gB_MySQL? "INT":"INTEGER", gB_MySQL ? ", UNIQUE KEY `auth` (`auth`)" : "");

It's because the points are reseting on join and mapchange.

[Nickelony]

I think this is the next big think you should start working on because everyone is waiting for a fully functional rankings plugin that delivers all the necessary features (and doesn't suck).

I don't think you have to rewrite your plugin since it's very good and I gave you a (almost) fully working version of it (credit to Zipcore). The only think you have to do is to optimise it, because for some reason it's killing the database within 10 seconds. xD

[shavitush]

I'll rewrite it because I don't like the way I did things before, no worries! Rankings are basically the last thing I need to do before the timer is out of beta :).

[shavitush]

Closing as I made my own issue with a new design: #465