Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_config should check for names not present in config.default #58

Closed
ressy opened this issue Dec 14, 2020 · 0 comments · Fixed by #88
Closed

load_config should check for names not present in config.default #58

ressy opened this issue Dec 14, 2020 · 0 comments · Fixed by #88

Comments

@ressy
Copy link
Member

ressy commented Dec 14, 2020

Currently load_config will return whatever structure is in a given YAML file, but there's no error or warning message for unrecognized entries. All valid names should already be present in config.defaults (even if they just point to NULL) so this should be used as a simple check when loading configurations. This would easily catch YAML formatting problems like key:val versus key: val since the former would show a mismatch with the default config.

@ressy ressy added this to the Version 0.3.2 milestone Dec 14, 2020
@ressy ressy modified the milestones: Version 0.3.2, Version 0.4.0 Feb 10, 2022
@ressy ressy modified the milestones: Version 0.4.0, Version 0.5.0 Apr 19, 2022
@ressy ressy modified the milestones: Version 0.5.0, Version 0.4.1 Nov 12, 2022
@ressy ressy closed this as completed in #88 Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant