Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated Tests for Backwards Compatibility Imports #14

Closed
shawnbrown opened this issue Jun 25, 2016 · 1 comment
Closed

Isolated Tests for Backwards Compatibility Imports #14

shawnbrown opened this issue Jun 25, 2016 · 1 comment
Milestone

Comments

@shawnbrown
Copy link
Owner

Datatest provides backwards compatibility via sub-packages in datatest.__past__. Importing a sub-package will modify datatest's behavior by applying monkey patches.

Care needs to be taken to isolate the side-effects of these imports because their default behavior is to apply global state changes to datatest, itself.

@shawnbrown
Copy link
Owner Author

This is done: c90080c

I decided to isolate these tests by putting them in separate files and adding test_past_subprocesses.py which runs each submodule test using subprocess.Popen.

Implementing module isolation with multiprocessing or threading modules looked to be needlessly complex.

@shawnbrown shawnbrown added this to the 0.7.0 milestone Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant