Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basedata: use GetFeatureCount in shapefile imports #885

Closed
shawnlaffan opened this issue Oct 23, 2023 · 0 comments · Fixed by #886
Closed

Basedata: use GetFeatureCount in shapefile imports #885

shawnlaffan opened this issue Oct 23, 2023 · 0 comments · Fixed by #886
Assignees
@shawnlaffan
Labels
data import
Milestone
Release_5.0

Comments

@shawnlaffan
Copy link
Owner

The progress dialogue in the shapefile imports calculates the number of features by iterating over the entire data set. This slows down the import of large data sets since we double iterate.

This approach is a leftover from when GDAL did not support this method for shapefiles, instead returning -1.

Support in GDAL was added some time ago so we should start using it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
data import
Projects
None yet
Milestone
Release_5.0
Development

Successfully merging a pull request may close this issue.

Feature data imports: use GetFeatureCount for progress dialogue shawnlaffan/biodiverse
1 participant
@shawnlaffan