Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictions is performed wrongly. #11

Closed
shayandavoodii opened this issue May 3, 2023 · 0 comments · Fixed by #18
Closed

Predictions is performed wrongly. #11

shayandavoodii opened this issue May 3, 2023 · 0 comments · Fixed by #18
Assignees

Comments

@shayandavoodii
Copy link
Owner

https://github.com/shayandavoodii/OnlinePortfolioSelection.jl/blob/ba5712caa3d4384936d49eb37b2a557e70df2e21/src/Algos/RPRT.jl#LL76C1-L76C1

With assuming t=w=5, relative_prices[:, t-w+1:t-1] is relative_prices[:, 1:4]. Hence, it includes the last 4 RPs instead of 5 (consider that w=5, so 5 last relative prices should be included in the prediction.)
Note that prediction is performed using predict_relative_price(relative_prices[:, t-w+1:t-1]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant