exclude_columns does not work for ColumnsBasedPipelineStage

[jjlee88]

When setting exclude_columns as a list of strings in the constructor of ColumnsBasedPipelineStage the member variable self._exclude_columns is set to a tuple instead of the passed in list. This leads to errors with __get_cols_by_arg which ends up returning the tuple and not the list itself.

Code where the issue appears to be

pdpipe/pdpipe/core.py

Line 602 in 763320d

self._exclude_columns = self._interpret_columns_param(

The line which seems incorrect is linked above. _interpret_columns_param returns a tuple, so we should be assigning the individual components of the tuple, in that line, as opposed to assigning the entire return value to 'self._exclude_columns'; something like

self._exclude_columns, _ = self._interpret_columns_param(...

[shaypal5]

Right you are! Thank you for catching this!

I'll fix this and add a test.

It shouldn't be discarded, by the way. The second element is an str representation of the columns to be discarded. It will be used to construct the pipeline description string.

[shaypal5]

Done. The new test now catches this error:
https://github.com/pdpipe/pdpipe/actions/runs/2313073586

And the same test passes for the fix:
https://github.com/pdpipe/pdpipe/actions/runs/2313093564

[jjlee88]

Thank you for fixing it and thank you for writing this library!

[shaypal5]

No problem! I wrote it for fun, and it's an immense pleasure to have other people find use for it.