Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: core: support autotune #19

Merged
merged 5 commits into from Jan 20, 2022
Merged

WIP: core: support autotune #19

merged 5 commits into from Jan 20, 2022

Conversation

dimidd
Copy link
Contributor

@dimidd dimidd commented Jan 10, 2022

Hi, added support for auto-tuning. Please LMK if you support this direction, and I'll add documentation and more tests to make it a mergeable PR.

Signed-off-by: Dimid Duchovny dimidd@localize.city

Signed-off-by: Dimid Duchovny <dimidd@localize.city>
@shaypal5 shaypal5 force-pushed the master branch 4 times, most recently from 1fc7214 to 25600da Compare January 13, 2022 13:01
@shaypal5
Copy link
Owner

shaypal5 commented Jan 13, 2022

Great! :)

I moved the CI from travis to GitHub Actions. Please rebase your commit over the current head of master so we can have tests and linting running for this PR, and then continue to add documentation and tests.

Signed-off-by: Dimid Duchovny <dimidd@localize.city>
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #19 (e7a6281) into master (0cf3f4e) will increase coverage by 2.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   96.00%   98.46%   +2.46%     
==========================================
  Files           2        2              
  Lines         175      195      +20     
  Branches       30       33       +3     
==========================================
+ Hits          168      192      +24     
+ Misses          6        2       -4     
  Partials        1        1              
Impacted Files Coverage Δ
skift/core.py 98.07% <100.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf3f4e...e7a6281. Read the comment docs.

Signed-off-by: Dimid Duchovny <dimidd@localize.city>
@shaypal5
Copy link
Owner

@dimidd
Can you see the coverage issues on this PR?

Signed-off-by: Dimid Duchovny <dimidd@localize.city>
@dimidd
Copy link
Contributor Author

dimidd commented Jan 20, 2022

Fixed

Copy link
Owner

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Outstanding, man. :)

@shaypal5 shaypal5 merged commit 2bfbf0e into shaypal5:master Jan 20, 2022
shaypal5 pushed a commit that referenced this pull request Jan 20, 2022
* core: support autotune

Signed-off-by: Dimid Duchovny <dimidd@localize.city>

* test: add autotune test

Signed-off-by: Dimid Duchovny <dimidd@localize.city>

* update README

Signed-off-by: Dimid Duchovny <dimidd@localize.city>

* test: add tests with numpy arrays

Signed-off-by: Dimid Duchovny <dimidd@localize.city>

Co-authored-by: Dimid Duchovny <dimidd@localize.city>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants