Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up Train and Inference #32

Closed
shaz13 opened this issue Mar 28, 2020 · 3 comments
Closed

Cleaning up Train and Inference #32

shaz13 opened this issue Mar 28, 2020 · 3 comments
Labels
no-issue-activity

Comments

@shaz13
Copy link
Owner

shaz13 commented Mar 28, 2020

IMO, we have to further clean-up the training and inference part.

Open to debate to have this structure --
current apis --> app (rename)
core folder --> moved to (app/core/)

The current core folder is not accessible from in APIs controls.
Also, its bad practise importing the top-level package. @AdityaSoni19031997

  • Core is exposed in the root. When the part should be hidden in-app/ or similar structure.
    Both in keeping favour of structure and security part.

Let me know if you have any better structure in place
@AdityaSoni19031997
Copy link
Contributor

Sure it sounds fine! We can move thing's around definitely.

@github-actions
Copy link

This issue hasn't received attention for a while. Can we do something about it? 🙇🏻‍♂️

@github-actions github-actions bot closed this as completed Jun 5, 2020
@shaz13 shaz13 reopened this Jun 11, 2020
@shaz13 shaz13 reopened this Jun 27, 2020
@shaz13 shaz13 mentioned this issue Jun 27, 2020
Merged
@shaz13
Copy link
Owner Author

shaz13 commented Jun 28, 2020

Closed

@shaz13 shaz13 closed this as completed Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdityaSoni19031997 @shaz13