Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safe Support #21

Closed
SonOfMosiah opened this issue Oct 17, 2023 · 12 comments
Closed

Add Safe Support #21

SonOfMosiah opened this issue Oct 17, 2023 · 12 comments
Labels
soon Planned, targeting a near-future release

Comments

@SonOfMosiah
Copy link

Additional requirements here: https://docs.safe.global/safe-core-aa-sdk/safe-apps/get-started#basic-requirements

@shazow shazow added the soon Planned, targeting a near-future release label Oct 17, 2023
@shazow
Copy link
Owner

shazow commented Oct 17, 2023

Great idea, thanks for tracking. Any interest in doing a PR? :)

@SonOfMosiah
Copy link
Author

Absolutely. I'll try my hand at adding this in.

@shazow
Copy link
Owner

shazow commented Oct 19, 2023

Fantastic! Let me know if you have any trouble getting going, I'd like to make callthis more contributor-friendly.

@shazow
Copy link
Owner

shazow commented Feb 10, 2024

Added a manifest in 790fb9c, pretty sure it's working now? Didn't need to do anything special for the provider.

@shazow shazow closed this as completed Feb 10, 2024
@SonOfMosiah
Copy link
Author

I think Safe also requires the app to "eager connect" or "auto connect" to the safe wallet.

@shazow
Copy link
Owner

shazow commented Feb 11, 2024

@SonOfMosiah Does it not work for you rn? I think whatever I did for my custom wallet connecting happened to be compatible with what Safe does. 🙃

@SonOfMosiah
Copy link
Author

Is the latest live on callthis.link? Wasn't able to connect through app.safe.global

@shazow
Copy link
Owner

shazow commented Feb 11, 2024

Ah you're right, it looked like it was working but it was using the wrong wallet.

I think it's actually also a CORS issue at the moment.

@shazow shazow reopened this Feb 11, 2024
@shazow
Copy link
Owner

shazow commented Feb 11, 2024

Do you have any (working) links handy for how eager/auto connect is supposed to work? Looks like everything is 404 these days. -_-

@shazow
Copy link
Owner

shazow commented Feb 11, 2024

@shazow shazow closed this as completed in 7add461 Feb 12, 2024
@shazow
Copy link
Owner

shazow commented Feb 12, 2024

Alright that was more annoying than I hoped but should do the trick, can you confirm when you get a chance? @SonOfMosiah

@shazow
Copy link
Owner

shazow commented Feb 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soon Planned, targeting a near-future release
Projects
None yet
Development

No branches or pull requests

2 participants