-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Safe Support #21
Comments
Great idea, thanks for tracking. Any interest in doing a PR? :) |
Absolutely. I'll try my hand at adding this in. |
Fantastic! Let me know if you have any trouble getting going, I'd like to make callthis more contributor-friendly. |
Added a manifest in 790fb9c, pretty sure it's working now? Didn't need to do anything special for the provider. |
I think Safe also requires the app to "eager connect" or "auto connect" to the safe wallet. |
@SonOfMosiah Does it not work for you rn? I think whatever I did for my custom wallet connecting happened to be compatible with what Safe does. 🙃 |
Is the latest live on callthis.link? Wasn't able to connect through app.safe.global |
Ah you're right, it looked like it was working but it was using the wrong wallet. I think it's actually also a CORS issue at the moment. |
Do you have any (working) links handy for how eager/auto connect is supposed to work? Looks like everything is 404 these days. -_- |
Ah found it via archive.org https://github.com/safe-global/safe-apps-sdk/tree/main/packages/safe-apps-provider |
Alright that was more annoying than I hoped but should do the trick, can you confirm when you get a chance? @SonOfMosiah |
Add Safe App Provider
Create a manifest.json
Additional requirements here: https://docs.safe.global/safe-core-aa-sdk/safe-apps/get-started#basic-requirements
The text was updated successfully, but these errors were encountered: