Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If 2 blocks of bytes are following, the second label won't appear #2

Closed
shazz opened this issue Jan 24, 2021 · 0 comments
Closed

If 2 blocks of bytes are following, the second label won't appear #2

shazz opened this issue Jan 24, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@shazz
Copy link
Owner

shazz commented Jan 24, 2021

The current code tries to gather all consecutive bytedata and do not split them if there is a label in the middle.

                    #TODO: break if a label is defined in the middle else won't be shown
                    # won't work with process_byte bool
                    try:
                        while adr+nb_bytes in self.instructions and isinstance(self.instructions[adr+nb_bytes], ByteData):
                            nb_bytes += 1
@shazz shazz self-assigned this Jan 24, 2021
@shazz shazz added the enhancement New feature or request label Jan 24, 2021
@shazz shazz added this to To do in Shazzam devboard via automation Jan 24, 2021
@shazz shazz moved this from To do to In Progress in Shazzam devboard Jan 30, 2021
@shazz shazz closed this as completed in 9f721fc Jan 30, 2021
Shazzam devboard automation moved this from In Progress to Done Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant