Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scrolling finite #8

Closed
ZiroDiv opened this issue Nov 5, 2016 · 7 comments
Closed

Make scrolling finite #8

ZiroDiv opened this issue Nov 5, 2016 · 7 comments

Comments

@ZiroDiv
Copy link

ZiroDiv commented Nov 5, 2016

In the current version you can turn the wheel to left or to the right infinite times.
I would like the option to have it finite and stop the scrolling at the max or min values, something like a volume control. Then the library could be used as an alternative to a seek bar.

@shchurov
Copy link
Owner

shchurov commented Nov 5, 2016

@ZiroDiv, hi there!
Have you checked setEndLock(boolean lock)?

@ZiroDiv
Copy link
Author

ZiroDiv commented Nov 6, 2016

Thanks, this is just what I wanted!
Do you think it would be useful to add a setMaximumAngle(double radiant) function? This should limit the rotation of the wheel to an angle below 360 degrees. This method would allow setting a more sensitive handling.

Above this angle no marks should be drawn and I suppose that endlock should be true if a max rotation angle is set.

@shchurov
Copy link
Owner

shchurov commented Nov 6, 2016

@ZiroDiv, could you provide a usecase for this feature? I can't imagine why rotating it 360 instead of - let's say - 270 can be a problem.

@ZiroDiv
Copy link
Author

ZiroDiv commented Nov 7, 2016

A use case is having a more sensitive control i.e. bigger relative change for a smaller scroll. It can be annoying having to flip several times to change from min to max.
Also the look and feel will be better as it makes sense to stop the scrolling at a point where there are no more marks.

@shchurov
Copy link
Owner

shchurov commented Nov 7, 2016

@ZiroDiv, that sounds reasonable. I will think about the optimal way to do it. Also feel free to PR it if you want.

@ZiroDiv
Copy link
Author

ZiroDiv commented Nov 8, 2016

@shchurov please do think about it and point me out what parts need to be changed. I will try to work on it when I have some time.

@shchurov
Copy link
Owner

shchurov commented Mar 3, 2017

Sorry, completely forgot about this issue. Closing it since there were no activity for a while.

@shchurov shchurov closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants