Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning results of varying length #6

Closed
tomholub opened this issue Dec 8, 2014 · 2 comments
Closed

Returning results of varying length #6

tomholub opened this issue Dec 8, 2014 · 2 comments

Comments

@tomholub
Copy link

tomholub commented Dec 8, 2014

Depending on the secret, the shares have different length. Based on spec it should always be the same length as the original secret.

Correct length:

>>> SecretSharer.split_secret("205fcb5bd65d590c3b187a88bce077b9", 3, 5)
['1-26d92b6af22b9e72813806200d81f6d0', '2-6a71a977eeab9bb01a042934fd63299', '3-3fc998e17c9aaae5bc512fe283dd2b13', '4-5240a648eb3b71f2b14ace0da996e03f', '5-3e0c42cdcacd0ee1e08d1d14c103521d']

Longer than expected:

>>> SecretSharer.split_secret("c61b5432ae2436d8fc29ae38a205227c", 3, 5)
['1-63571f1a138698048c6cb5c743237939b0b1a021a5471a3c843eae8022a40db8', '2-66698be3fa70cdd2083df9367463f9c81193fadc6194c1494f264dc19b91d1ef', '3-937465db4bea1687373ca4d93c181abe8c26462e30d2bff5ce08bfd0cce6f21', '4-4bc04e87427012c7ce0e290ca13c10e5363cdcb529b05a5ead6d69327659e677', '5-2e04a460a38521f0180d15739cd3a773fa0363d3357e4c6740cce561d83436c8']
@shea256
Copy link
Owner

shea256 commented Feb 10, 2016

Hi thanks for mentioning this @tomholub and please excuse the delay. I should have addressed your concerns in the latest branch I pushed. You can see the full discussion here: #16

@shea256
Copy link
Owner

shea256 commented Feb 10, 2016

Closing this now and we can continue the discussion in #16 if necessary.

@shea256 shea256 closed this as completed Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants